Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add astroturf vite plugin #701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add astroturf vite plugin #701

wants to merge 1 commit into from

Conversation

azat-io
Copy link

@azat-io azat-io commented May 9, 2021

Added plugin for Vite

Currently we have the same problem as in Parcel with saving temporary css files #610

It means that you have to use this plugin with some delete plugin as here #111 (comment)

@jquense
Copy link
Contributor

jquense commented May 9, 2021

This is great, I'm not sure if it should go here since I don't use vite, and would be afraid it'd break or get out of date without realizing

@azat-io
Copy link
Author

azat-io commented May 9, 2021

@jquense There is webpack loader in this repo, so why not have Vite plugin here?
Also, I can can try to add some tests and some code with Vite to /example folder.

@jquense
Copy link
Contributor

jquense commented May 9, 2021

it's just a matter of what i can reasonably maintain. I use webpack so i can be sure the webpack loader is up to date, tested and working. I don't use Vite and don't know it's plugin system at all so i'd not be able to update it, fix bugs, or answer questions about it

@azat-io
Copy link
Author

azat-io commented May 12, 2021

@jquense Okay, I'll move this plugin to my repo and create pull request to Astroturf docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants